feat(AgmGeocoder): add geocoder service and tests #1743
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
==========================================
+ Coverage 47.68% 50.45% +2.76%
==========================================
Files 41 43 +2
Lines 1839 1881 +42
Branches 167 170 +3
==========================================
+ Hits 877 949 +72
+ Misses 958 928 -30
Partials 4 4
Continue to review full report at Codecov.
|
ghost
added
the
|
Hi @doom777, thank you very much for your feedback. It really helps me improving my code. |
- Export new map types in the correct place Addresses PR sebholstein#1743 review
|
@doom777 i've done the required changes and pushed them to the branch. |
DefJunx
force-pushed
the
geolocator-service
branch
from
997b842
to
2826406
Compare
|
@doom777 I also rebased together all the commits, leaving the implementation message. Again, you might hate me after all these notifications but please don't! |
DefJunx
force-pushed
the
geolocator-service
branch
from
dbaad6a
to
fda0113
Compare
|
Just wanted to say this looks really good. Thanks for doing it! |
- add geocoder service - add interfaces to support geocoder request and response - add test cases Implements sebholstein#1694
DefJunx
force-pushed
the
geolocator-service
branch
from
7dcd361
to
6ee3de7
Compare
- add geocoder service - add interfaces to support geocoder request and response - Add check to see if the geocoder instance is defined; if not, return an empty array of results
- add initial test implementation implements SebastianM#1694
- Fix wrong geocodeMock jest function implements SebastianM#1694
- avoid method being called without google being initialized - Add geocoder interface Implements sebholstein#1694
- Changed geocoder service structure Implements sebholstein#1694
- add geocoder object as private observable to follow style of other services Implements sebholstein#1694
- add test implements sebholstein#1694
DefJunx
force-pushed
the
geolocator-service
branch
from
70e252c
to
6ee3de7
Compare
|
hey, you missed my latest change request |
- Add providedIn flag to service Injectable decorator
|
@doom777 no no, I saw it. though I had a fight with git because for some reason, when I pulled my changes on another machine I screwed everything up so I had to do some work to fix it. Let me know if everything is in place now, it should be I think. |
and patch tests - Remove unwanted test expectation - Change geocoder Observable implementation to avoid instantiating multiple geocoder object
- Remove unwanted test expectation - Change geocoder Observable implementation to avoid instantiating multiple geocoder object
- Simplify creation of connectableGeocoder observable
ghost
merged commit - add geocoder service - add interfaces to support geocoder request and response - add test cases Implements: sebholstein#1694
implements #1694