Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support google maps drawing library #1749

Merged
5 commits merged into from Nov 5, 2019
Merged

feat: support google maps drawing library #1749

5 commits merged into from Nov 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 18, 2019

enable user to draw shapes on the map using maps drawing library

fixes: #1172

Ephraim added 2 commits October 18, 2019 13:45
add ControlOptions types to map-types exports, and focus map-type
exports in one place
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #1749 into master will decrease coverage by 2.18%.
The diff coverage is 1.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   50.02%   47.84%   -2.19%     
==========================================
  Files          43       47       +4     
  Lines        1905     1992      +87     
  Branches      171      176       +5     
==========================================
  Hits          953      953              
- Misses        948     1035      +87     
  Partials        4        4
Impacted Files Coverage Δ
...ages/drawing/directives/drawing-manager-trigger.ts 0% <0%> (ø)
packages/core/map-types.ts 0% <0%> (ø) ⬆️
packages/drawing/directives/drawing-manager.ts 0% <0%> (ø)
packages/drawing/google-drawing-types.ts 0% <0%> (ø)
packages/drawing/drawing.module.ts 0% <0%> (ø)
packages/core/directives/marker.ts 37.06% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a858e...6a6f78b. Read the comment docs.

@ghost ghost merged commit a1a17a6 into sebholstein:master Nov 5, 2019
@ghost ghost deleted the drawingmanager branch November 6, 2019 09:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request : Add support for drawing manager
2 participants