-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Core): Language config bug fixed #1775
fix(Core): Language config bug fixed #1775
Conversation
language config was not working when it is set in forRoot method
Codecov Report
@@ Coverage Diff @@
## master #1775 +/- ##
=======================================
Coverage 47.97% 47.97%
=======================================
Files 47 47
Lines 1999 1999
Branches 177 177
=======================================
Hits 959 959
Misses 1036 1036
Partials 4 4
Continue to review full report at Codecov.
|
Thanks, I am embarassed as it's my bug. Can you just add another test showing that when a |
@doom777 |
No, because LOCALE_ID is always set to be the locale of the entire app. |
Ok, I will add that spec. |
@doom777 Can you please publish a new version with this fix? :) |
please publish :) |
@alisahinozcelik, @doom777 please note that the latest commit is not included in the latest npm package. (v1.1.0) For that reason map language is set always with LOCALE_ID. Could you please publish a fix. Thank you. |
language config was not working when it is set in forRoot method