Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add placeId to map click events #691

Closed
moneal opened this issue Oct 2, 2016 · 7 comments
Closed

Feature request: Add placeId to map click events #691

moneal opened this issue Oct 2, 2016 · 7 comments

Comments

@moneal
Copy link

moneal commented Oct 2, 2016

When clicking on a point of interest on a map the event returns the placeId of the location clicked. It would be nice to get this in the click event with the lat,lng.

@yosigolan
Copy link
Contributor

Hey.
any new with this? it will be great to have this feature.

Thanks

@yosigolan
Copy link
Contributor

For any one interested, i created a pull request fro this. i cant commit it since i dont have permissions. @SebastianM , please update my permissions in order to push the feature.

@benjcallaghan
Copy link

@yosigolan I am very interested in this feature, and I would love to see your work included. However, I cannot find your pull request. Can you provide a link to your repository or to the pull request?

@yosigolan
Copy link
Contributor

@SebastianM thank you for getting back to me.
i must be missing something. in order to create a pull request i need to select a branch but i cant push my branch since i dont have permissions. what am i missing?

Yosi

@benjcallaghan
Copy link

@yosigolan I am not the maintainer of this project, but I do have a strong interest in getting your work approved and included in the next release. The standard practice when contributing to a GitHub project is to fork the repository. You can then make any changes you like in your own personal copy. When you are ready to merge, you can then open a pull request from your fork back into the main repository. This is different than cloning the repository and making changes locally. Let me know if you have any more questions.

@yosigolan
Copy link
Contributor

@benjcallaghan thanks for the explanation! i will do it.

Yosi

yosigolan added a commit to yosigolan/angular-google-maps that referenced this issue Feb 24, 2019
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked.

closes issue sebholstein#691.
yosigolan added a commit to yosigolan/angular-google-maps that referenced this issue Mar 6, 2019
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked.

closes issue sebholstein#691.

fixes for @benjcallaghan code review comments
LeandroPereiraDaCruz pushed a commit to LeandroPereiraDaCruz/angular-google-maps that referenced this issue Mar 9, 2019
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked.

closes issue sebholstein#691.
LeandroPereiraDaCruz pushed a commit to LeandroPereiraDaCruz/angular-google-maps that referenced this issue Mar 9, 2019
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked.

closes issue sebholstein#691.

fixes for @benjcallaghan code review comments
@stale
Copy link

stale bot commented May 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 22, 2019
@stale stale bot closed this as completed May 29, 2019
yosigolan added a commit to yosigolan/angular-google-maps that referenced this issue Jun 2, 2019
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked.

closes issue sebholstein#691.

fixes for @doom777 code review comments
yosigolan added a commit to yosigolan/angular-google-maps that referenced this issue Jun 2, 2019
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked.

closes issue sebholstein#691.

fixes for @doom777 code review comments
ghost pushed a commit that referenced this issue Jun 3, 2019
* feat: allow disabling a "point of interest" default info window
* feat: Add placeId to map click events

when clicking on a point of interest on a map the emiting event will include the `placeId` of the location clicked.
allow disabling a "point of interest" default info window. Use it by passing a boolean value to the new property isToShowDefaultInfoWindowForIcons when initializing the map. Default value is `true`.

closes issue #691.
closes issue #1539.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants