Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error handling: String instead of numbers #771

Closed
thanatos11 opened this issue Nov 25, 2016 · 1 comment
Closed

improve error handling: String instead of numbers #771

thanatos11 opened this issue Nov 25, 2016 · 1 comment

Comments

@thanatos11
Copy link

Issue description
When the pins or other elements on map are presented with strings instead of number, the elements or pins do not show on the map, there is no feedback in console, no error.

Steps to reproduce and a minimal demo of the problem

made a pin and served latitude and longitude coordinates in string format. That pin is not rendered.

Expected/desired behavior

Whould be great if an error would show in console. Even better if in converts it to number and displays a warning.

@sebholstein
Copy link
Owner

@thanatos11 I agree, this can be a really annoying thing. (No errors, no marker). We should try to convert the value if it's a string.

arhill05 added a commit to arhill05/angular-google-maps that referenced this issue Nov 3, 2017
change from no warnings/errors/functionality to
automatically converting latitude and longitude inputs
to numbers if they are not of type number

closes sebholstein#771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants