Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Icon instead of Icons #948

Closed
kareljuricka opened this issue Mar 22, 2017 · 1 comment
Closed

Bug: Icon instead of Icons #948

kareljuricka opened this issue Mar 22, 2017 · 1 comment

Comments

@kareljuricka
Copy link

Issue description
In google-map-types.d.ts - Interface PolylineOptions shoud contain icons?: Array;
instead of icon?: Array;

That ending 's' is important, see here - https://developers.google.com/maps/documentation/javascript/examples/overlay-symbol-dashed.

Current behavior
Its possible to use with ANY but Typescript strong typings can not be used.

Expected/desired behavior
Generate PolylineOptions with type PolylineOptions instead of ANY.

angular2 & angular-google-maps version
0.17.0

Other information
So only what have to be done is add that ending 's' to make it correct.

@kareljuricka kareljuricka changed the title Bug: Icon instead Icons Bug: Icon instead of Icons Mar 22, 2017
@sebholstein
Copy link
Owner

@kareljuricka Thx for the report. Do you have time to send a PR?

sebholstein pushed a commit that referenced this issue Jun 2, 2018
Changes the typename from 'Icon' to 'Icons' according to the Google API.

fixes #948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants