Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info Window - Support initial open state #382

Closed
brian-singer opened this issue Jun 2, 2016 · 2 comments
Closed

Info Window - Support initial open state #382

brian-singer opened this issue Jun 2, 2016 · 2 comments

Comments

@brian-singer
Copy link
Contributor

brian-singer commented Jun 2, 2016

@SebastianM
Question
Regarding markers and infowindow...
If i add a marker on user map click is it possible after this event to immediately display the infowindow? Thanks

@brian-singer
Copy link
Contributor Author

brian-singer commented Jun 3, 2016

In SebmGoogleMapMarker

I believe we would need to set an attribute of the marker: showInfoWindow [true,false]

Unless I totally miss something.

`
/** @internal */
ngOnChanges(changes: { [key: string]: SimpleChange }) {
if (typeof this.latitude !== 'number' || typeof this.longitude !== 'number') {
return;
}
if (!this._markerAddedToManger) {
this._markerManager.addMarker(this);
this._markerAddedToManger = true;
this._addEventListeners();
return;
}
if (changes['latitude'] || changes['longitude']) {
this._markerManager.updateMarkerPosition(this);
}
if (changes['title']) {
this._markerManager.updateTitle(this);
}
if (changes['label']) {
this._markerManager.updateLabel(this);
}
if (changes['draggable']) {
this._markerManager.updateDraggable(this);
}
if (changes['iconUrl']) {
this._markerManager.updateIcon(this);
}

// Start enhancement
if(changes['showInfoWindow']) {
....
}
}
`

@brian-singer
Copy link
Contributor Author

Additionally it would be cool to prevent more than 1 infowindow open at once....

@sebholstein sebholstein changed the title Info Window Info Window - Support initial open state Jun 5, 2016
sebholstein added a commit that referenced this issue Jun 6, 2016
The new isOpen binding adds support for setting
the open state in a declarative way.

Closes #382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants