Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zone.js and RxJS as peer dependency #792

Closed
DavidGangel opened this issue Dec 16, 2016 · 0 comments
Closed

Remove zone.js and RxJS as peer dependency #792

DavidGangel opened this issue Dec 16, 2016 · 0 comments

Comments

@DavidGangel
Copy link

Issue description
Your library has dependencies for zone.js and RxJS.
As a result when a new angular2 gets released and it has an upgraded version of the 2 dependencies then we have a problem.

More information:
angular/angular#13518

Suggested solution:
angular/angular#13518 (comment)

Can you please take a look and fix it?

Thank you.

angular2 & angular2-google-maps version
ALL
sebholstein added a commit that referenced this issue Dec 16, 2016
@sebholstein
fix(package): remove indirect peerDependencies
c8e1a70 
This removes indirect peerDependencies from the package.json

Closes #792
@sebholstein sebholstein mentioned this issue Dec 16, 2016
Closed
sebholstein added a commit that referenced this issue Dec 16, 2016
@sebholstein
fix(package): remove indirect peerDependencies
0256d3a 
This removes indirect peerDependencies from the package.json

Closes #792
sebholstein added a commit that referenced this issue Dec 16, 2016
@sebholstein
fix(package): remove indirect peerDependencies
5146622 
This removes indirect peerDependencies from the package.json

Closes #792
sebholstein added a commit that referenced this issue Dec 16, 2016
@sebholstein
fix(package): remove indirect peerDependencies
2155c5b 
This removes indirect peerDependencies from the package.json
and updates a few devDependencies.

Closes #792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidGangel