Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<td> attribute is valign not vertical-align #169

Closed
skybber opened this issue Apr 13, 2023 · 5 comments
Closed

<td> attribute is valign not vertical-align #169

skybber opened this issue Apr 13, 2023 · 5 comments
Assignees
@SebastianStehle
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@skybber
Copy link
Contributor

skybber commented Apr 13, 2023

At the following line atribute vertical-align= instead of valign= is appended to attributes:

mjml-net/Mjml.Net/Components/Body/ColumnComponent.cs

Line 215 in f834b2b

.Attr("vertical-align", child.GetAttribute("vertical-align"))

@SebastianStehle
Copy link
Owner

Where do you see it here?

https://github.com/mjmlio/mjml/blob/master/packages/mjml-column/src/index.js#L298

@skybber
Copy link
Contributor Author

skybber commented Apr 14, 2023

I think that's wrong even in JS implementation:

https://github.com/mjmlio/mjml/blob/master/packages/mjml-column/src/index.js#L261

@SebastianStehle
Copy link
Owner

Probably. But then tests might fail...

@SebastianStehle
Copy link
Owner

Will be fixed as soon as the mjml bug is fixed: mjmlio/mjml#2684

@SebastianStehle SebastianStehle added bug Something isn't working wontfix This will not be worked on labels May 25, 2023
@SebastianStehle SebastianStehle self-assigned this May 25, 2023
@SebastianStehle
Copy link
Owner

Should already be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebastianStehle SebastianStehle

Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SebastianStehle @skybber