Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mj-button #3

Closed
Tracked by #1
SebastianStehle opened this issue Mar 13, 2022 · 7 comments · Fixed by #27
Closed
Tracked by #1

mj-button #3

SebastianStehle opened this issue Mar 13, 2022 · 7 comments · Fixed by #27
Assignees
@LiamRiddell

Comments

@SebastianStehle
Copy link
Owner

No description provided.

@SebastianStehle SebastianStehle mentioned this issue Mar 13, 2022
Closed
43 tasks
@LiamRiddell
Copy link
Collaborator

@SebastianStehle I'm happy to pick this component up.

@LiamRiddell LiamRiddell self-assigned this Mar 13, 2022
@SebastianStehle
Copy link
Owner Author

I see that you also need values like getShorthandAttrValue ... I am working on this right now.

@LiamRiddell
Copy link
Collaborator

I see that you also need values like getShorthandAttrValue ... I am working on this right now.

Appreciate that, I've nearly got initial draft complete. Minus the attribute work which I'll update now.

@LiamRiddell
Copy link
Collaborator

LiamRiddell commented Mar 13, 2022 •
edited

@SebastianStehle Question, what's the best approach to getting the text content of the button? I tried using RenderChildren but it doesn't pick up Text nodes.

Apologies, I think I need to use node.GetContent() and pass it into renderer.Content().

@SebastianStehle
Copy link
Owner Author

Yes, exactly.

@SebastianStehle
Copy link
Owner Author

I have pushed my changes with mj-images. Have forgotten to create a PR :(

@LiamRiddell
Copy link
Collaborator

I have pushed my changes with mj-images. Have forgotten to create a PR :(

No problem! It shouldn't affect anything!

@LiamRiddell LiamRiddell linked a pull request Mar 13, 2022 that will close this issue
Button #27
Merged
@LiamRiddell LiamRiddell mentioned this issue Mar 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LiamRiddell LiamRiddell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Button SebastianStehle/mjml-net
2 participants
@SebastianStehle @LiamRiddell