Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section: Comments do not render properly with empty sections. #53

Closed
Tracked by #52
SebastianStehle opened this issue Mar 19, 2022 · 0 comments · Fixed by #60
Closed
Tracked by #52

Section: Comments do not render properly with empty sections. #53

SebastianStehle opened this issue Mar 19, 2022 · 0 comments · Fixed by #60
Labels
bug Something isn't working

Comments

@SebastianStehle
Copy link
Owner

SebastianStehle commented Mar 19, 2022 •
edited

They are correct, but we cannot write tests like that. Test with zero columns. See mj-group where I had a similar problem. You can fix it with adding the conditional comments to other places.
@SebastianStehle SebastianStehle mentioned this issue Mar 19, 2022
Closed
4 tasks
@SebastianStehle SebastianStehle added the bug Something isn't working label Mar 19, 2022
@SebastianStehle SebastianStehle changed the title Section: Comments do not render properly with empty sections. They are correct, but we cannot write tests like that. Test with zero columns. See mj-group where I had a similar problem. Section: Comments do not render properly with empty sections. Mar 19, 2022
@SebastianStehle SebastianStehle mentioned this issue Mar 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes the section conditionals. SebastianStehle/mjml-net
2 participants
@SebastianStehle @LiamRiddell