Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write high level tests for a few complex templates? #62

Closed
Tracked by #1
SebastianStehle opened this issue Mar 19, 2022 · 3 comments
Closed
Tracked by #1

Write high level tests for a few complex templates? #62

SebastianStehle opened this issue Mar 19, 2022 · 3 comments
Assignees

Comments

@SebastianStehle
Copy link
Owner

No description provided.

@SebastianStehle SebastianStehle mentioned this issue Mar 19, 2022
43 tasks
@SebastianStehle SebastianStehle self-assigned this Mar 19, 2022
@SebastianStehle
Copy link
Owner Author

@LiamRiddell I have pushed a test with Amario template and the test is green :)

I had to make a few bugfixes, but now it works. The only problem are the comments, but thats okay, I guess.

But I realized that we should not use https://mjml.io/ to create our expected html results, because it is not up to date and if you use the current version as a reference your tests can be wrong.

@LiamRiddell
Copy link
Collaborator

That's good to know! I'm going to add all of the MJML templates to the benchmarking project. As it was good for finding bugs. Furthermore, I may add then to the test runner so we can get all of the output for comparison.

@SebastianStehle
Copy link
Owner Author

The unit tests writes all htmls to a file already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants