Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coveralls build failure #32

Closed
dzhoshkun opened this issue Oct 5, 2017 · 4 comments
Closed

Fix Coveralls build failure #32

dzhoshkun opened this issue Oct 5, 2017 · 4 comments

Comments

@dzhoshkun
Copy link
Collaborator

After resolving #31 the Coveralls failure needs to be investigated.
@SebastianoF As far as I understand, the problem was related to Coveralls trawling through all the external dependency libraries, which was causing it to fail?

@dzhoshkun
Copy link
Collaborator Author

This line is important.

@dzhoshkun
Copy link
Collaborator Author

dzhoshkun commented Oct 14, 2017

@SebastianoF The --cover-package bruker2nifti argument restricts coverage stats to the bruker2nifti package only.
But that argument is not enabled in your .travis.yml

See my coveralls output: https://coveralls.io/github/dzhoshkun/bruker2nifti

@SebastianoF
Copy link
Owner

Hi! Thanks for checking (in the week end counts twice!).
Yep, flags are to be refactored. They are in this state awaiting for me understand a bit more how to use properly travis-CI + coveralls. Your suggestions provided me good starting points for this direction!

@SebastianoF
Copy link
Owner

Due to the recent discoveries about orientation (see issues #11 and #33), it seems that the user will always need a small amount manual adjustment for the conversion. Therefore a 100% coverage may be more an hindrance than an help.
Increasing the coverage for the core and utils modules can still be done, although if you agree, this repo may keep on surviving without coverall for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants