Use punycode more appropriately #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebmaster
requested changes
Jan 6, 2017
| @@ -12,6 +12,16 @@ function normalize(str) { // fix bug in v8 | |||
| return str.split('\u0000').map(function (s) { return s.normalize('NFC'); }).join('\u0000'); | |||
| } | |||
|
|
|||
| function containsNonASCII(str) { | |||
There was a problem hiding this comment.
Regexes seem to be much faster for this.
There was a problem hiding this comment.
Dang, I should have checked.
|
Regarding the test failures: A lot of that is just the inadequate description of the test suite by Unicode. Getting failures down is basically only a heuristic. |
|
Should also switch to punycode.js proper (the package) instead of using the node built-in module while we're at it. |
Previously we used punycode's toASCII and toUnicode exports, which implement incomplete parts of TR46 themselves (with buggy "is ASCII" checks until recently; see jsdom#5 and mathiasbynens/punycode.js#59. Now we usethe lower-level encode and decode exports, with appropriate tweaks to the surrounding code to more fully conform to the surrounding TR46 algorithm steps. This also upgrades to the latest punycode.js published on npm, instead of using the now-deprecated one bundled with Node.js. Fixes jsdom#5.
domenic
force-pushed
the
better-punycode
branch
from
c234e20
to
6ed50be
Compare
Sebmaster
approved these changes
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used punycode's toASCII and toUnicode exports, which implement incomplete parts of TR46 themselves (with buggy "is ASCII" checks until recently; see #5 and mathiasbynens/punycode.js#59. Now we usethe lower-level encode and decode exports, with appropriate tweaks to the surrounding code to more fully conform to the surrounding TR46 algorithm steps.
Fixes #5.
Still 488 failing tests before and after. However this improves jsdom/whatwg-url results on the host parser tests at web-platform-tests/wpt#4504 to only 3 failures none of which seem tr46 related.