Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not prepend http:// to URLs that already have a protocol #151

Open
dbrgn opened this issue Dec 2, 2022 · 0 comments
Open

Do not prepend http:// to URLs that already have a protocol #151

dbrgn opened this issue Dec 2, 2022 · 0 comments

Comments

@dbrgn
Copy link

dbrgn commented Dec 2, 2022

If the URL already contains a protocol (e.g. fdroidrepos://example.com), do not prepend http:// when sharing it.

See https://gitlab.com/fdroid/fdroidclient/-/merge_requests/1133 for the breakage that this can cause.

Related to #104.

My suggestion: If a string starts with ^[a-zA-Z0-9]+://, do not modify it in any way when opening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant