Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Get-GPPPassword #1064

Merged
merged 3 commits into from May 19, 2021
Merged

Added Get-GPPPassword #1064

merged 3 commits into from May 19, 2021

Conversation

ShutdownRepo
Copy link
Contributor

Added Get-GPPPassword in examples. It's a python script for extracting and decrypting Group Policy Preferences passwords using streams for treating files instead of mounting shares, allowing for running this script inside regular docker containers. This also allows for pass-the-hash, pass-the-ticket, pass-the-key, overpass-the-hash, features that the Metasploit Framework doesn't offer.

➡️ for those wondering, read this: what are GPP Passwords

Added Get-GPPPassword in examples. It's a python script for extracting and decrypting Group Policy Preferences passwords using streams for treating files instead of mounting shares, allowing for running this script inside regular docker containers. This also allows for pass-the-hash, pass-the-ticket, pass-the-key, overpass-the-hash, features that the Metasploit Framework doesn't offer.
@0xdeaddood 0xdeaddood added the in review This issue or pull request is being analyzed label Apr 24, 2021
Copy link
Collaborator

@0xdeaddood 0xdeaddood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShutdownRepo!
This is a great addition!

I have a couple of comments before merging it:

  • Some days ago, we refactored the target parsing functions. I made some changes in the script to use these new ones.
  • In the example, you are using the chardet module that is not included as a requirement in impacket. We prefer not to add new modules to the project, so we wonder if there is a way to avoid its use or replace it with a built-in module (e.g. xml.etree.ElementTree). Do you see this feasible?

examples/Get-GPPPassword.py Outdated Show resolved Hide resolved
examples/Get-GPPPassword.py Outdated Show resolved Hide resolved
ShutdownRepo and others added 2 commits April 29, 2021 21:58
Co-authored-by: 0xdeaddood <56035084+0xdeaddood@users.noreply.github.com>
Co-authored-by: 0xdeaddood <56035084+0xdeaddood@users.noreply.github.com>
@ShutdownRepo
Copy link
Contributor Author

Thank you for reviewing this 😃
The new utils functions are great, thanks for this!
However, the chardet is needed to detect encoding and allow for the main "big plus" behind Get-GPPPassword.py which is searching for cpasswords without having to mount any share. We didn't manage to find any alternative lib that's already in the requirements. I think adding this lib will be really useful (it's also used in #1019), and it's quite light too. What do you think?

@0xdeaddood
Copy link
Collaborator

Hey @ShutdownRepo!
Thanks again for the PR! We took some time to define if we included chardet... Merging!

@0xdeaddood 0xdeaddood merged commit 7c21156 into fortra:master May 19, 2021
@ShutdownRepo
Copy link
Contributor Author

Awesome! Thank you

@0xdeaddood 0xdeaddood removed the in review This issue or pull request is being analyzed label May 19, 2021
@p0dalirius
Copy link
Contributor

That's awesome ! Thanks for merging it ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants