Disable anonymous logon in ntlmrelayx #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, SMBSERVER allows anonymous logon. For ntlmrelayx, this is not desired since we're not interested in relaying an anonymous session, and ntlmrelayx even skips anonymous logons. After the patch for the PetitPotam exploit, the service now tries to logon with an anonymous session, but if we're returning STATUS_ACCESS_DENIED, the service will continue to NTLM authentication. This patch will create a new option for SMBSERVER that can disable anonymous logon via config_parser/serverConfig. Anonymous logon sessions will now return STATUS_ACCESS_DENIED.
|
Hi @ly4k! Great addition, thanks for the PR! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, SMBSERVER allows anonymous logon. For ntlmrelayx, this
is not desired since we're not interested in relaying an anonymous
session, and ntlmrelayx even skips anonymous logons. After the patch for
the PetitPotam exploit, the service now tries to logon with an anonymous
session, but if we're returning STATUS_ACCESS_DENIED, the service will
continue to NTLM authentication. This patch will create a new option for SMBSERVER
that can disable anonymous logon via config_parser/serverConfig.
Anonymous logon sessions will now return STATUS_ACCESS_DENIED.