Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Timeout and Six Times #25

Open
slingerbv opened this issue Aug 19, 2022 · 5 comments
Open

Job Timeout and Six Times #25

slingerbv opened this issue Aug 19, 2022 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@slingerbv
Copy link
Contributor

When a job times out and the database-api removes the job, the controller will try to finish the job for a total of 6 times, because it fails every time. It would be better to not do this.

@slingerbv slingerbv added enhancement New feature or request help wanted Extra attention is needed labels Aug 19, 2022
@gitcoinbot
Copy link

gitcoinbot commented Aug 28, 2022

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 weeks, 4 days from now.
Please review their action plans below:

1) psvnlsaikumar has been approved to start work.

Raised PR #30

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 100.14 USD (100.00 USD @ $1.0/USD) has been submitted by:

  1. @psvnlsaikumar

@slingerbv please take a look at the submitted work:


@slingerbv
Copy link
Contributor Author

Hi Sai,

obviously, changing only the number of try-outs is not what is asked here. There should be a condition: it should only try six times when it is not removed from the queue. So this is not the fix: the fix should be an if statement somewhere that checks whether the timeout has resulted in removal from the queue. And if so, then it should not retry six times. Otherwise, it should.

Curious to see what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants
@slingerbv @gitcoinbot and others