Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Curator should ignore empty list #10512

Closed
weslambert opened this issue Jun 5, 2023 · 1 comment
Closed

FIX: Curator should ignore empty list #10512

weslambert opened this issue Jun 5, 2023 · 1 comment
Assignees
Labels
2.4 Planned for 2.4.X

Comments

@weslambert
Copy link
Contributor

While debugging an issue with Curator not deleting for space (#10464), I noticed hundreds of lines like:

2023-06-01 14:10:38,175 ERROR Unable to complete action "close". No actionable items in list: <class 'curator.exceptions.NoIndices'>
2023-06-01 14:10:52,986 ERROR Unable to complete action "close". No actionable items in list: <class 'curator.exceptions.NoIndices'>

They were all the close and warm actions, whereas the delete actions all showed something like:

2023-06-01 14:10:06,118 INFO Skipping action "delete_indices" due to empty list: <class 'curator.exceptions.NoIndices'>

Obviously, this is an expected outcome, and not a true error, but it appears the delete action uses ignore_empty_list: True whereas the close and warm actions use continue_if_exception: False.

Security Onion Solutions devs, is there a reason behind this? If not, would it make sense to use ignore_empty_list: True on all actions? In my testing, changing selected close actions to ignore_empty_list: True removes the error and I haven't noticed any ill effects. Being able to search the log for 'ERROR' and only see actual errors would make troubleshooting easier.

Originally posted by @petiepooo in #10496

@weslambert weslambert added the 2.4 Planned for 2.4.X label Jun 5, 2023
@weslambert weslambert self-assigned this Jun 6, 2023
@weslambert
Copy link
Contributor Author

#10541

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4 Planned for 2.4.X
Projects
None yet
Development

No branches or pull requests

1 participant