Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Support filtering against multiple groupby charts #10856

Closed
jertel opened this issue Jul 28, 2023 · 1 comment
Closed

FIX: Support filtering against multiple groupby charts #10856

jertel opened this issue Jul 28, 2023 · 1 comment
Assignees
Milestone

Comments

@jertel
Copy link
Contributor

jertel commented Jul 28, 2023

Given a dashboard with the following query:

* | groupby -sankey event.dataset event.category* | groupby -pie event.category | groupby -bar event.module* | groupby event.dataset | groupby event.module* | groupby event.category | groupby observer.name | groupby source.ip | groupby destination.ip | groupby destination.port | groupby destination_geo.organization_name

Clicking one of the bars on the event.module bar chart brings up a Quick Action menu with links pre-populated with the wrong field. So if you click Include, it will add a filter for the event.dataset field instead of the event.module field.

The incorrect code is located in hunt.js::handleChartClick(), specifically this line that assumes to use the first field of the first graph:

            var chartGroupByField = this.groupBys[0].fields[0];
@dougburks
Copy link
Contributor

Tested and verified:

image

image

@jertel jertel added this to the 2.3.270 milestone Sep 11, 2023
@jertel jertel changed the title FIX: Dashboards with multiple groupby charts always filter by the first chart's, first groupby field FIX: Support filtering against multiple groupby charts Sep 11, 2023
@jertel jertel removed this from the 2.3.270 milestone Sep 11, 2023
@TOoSmOotH TOoSmOotH added this to the 2.4.20 milestone Sep 11, 2023
@jertel jertel modified the milestones: 2.4.20, 2.3.270 Sep 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants