Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Support Oinkcode values containing leading 0's #12506

Closed
jertel opened this issue Mar 5, 2024 · 1 comment · Fixed by #12507
Closed

FIX: Support Oinkcode values containing leading 0's #12506

jertel opened this issue Mar 5, 2024 · 1 comment · Fixed by #12507
Assignees
@jertel
Milestone
2.4.60

Comments

@jertel
Copy link
Contributor

jertel commented Mar 5, 2024

No description provided.

@jertel jertel self-assigned this Mar 5, 2024
@jertel jertel added this to the 2.4.60 milestone Mar 5, 2024
@jertel jertel linked a pull request Mar 5, 2024 that will close this issue
fix oinkcodes with leading zeros #12507
Merged
@jertel
Copy link
Contributor Author

jertel commented Mar 5, 2024

Example of applying idstools salt state using oinkcode 01234

Before:

                      -    docker exec so-idstools idstools-rulecat -v --suricata-version 6.0 -o /nsm/rules/suricata/ --merged=/nsm/rules/suricata/emerging-all.rules --force --etpro=
                      +    docker exec so-idstools idstools-rulecat -v --suricata-version 6.0 -o /nsm/rules/suricata/ --merged=/nsm/rules/suricata/emerging-all.rules --force --etpro=1234

After:

                      -    docker exec so-idstools idstools-rulecat -v --suricata-version 6.0 -o /nsm/rules/suricata/ --merged=/nsm/rules/suricata/emerging-all.rules --force
                      +    docker exec so-idstools idstools-rulecat -v --suricata-version 6.0 -o /nsm/rules/suricata/ --merged=/nsm/rules/suricata/emerging-all.rules --force --etpro=01234

@jertel jertel closed this as completed Mar 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jertel jertel

Labels
None yet
Projects
None yet
Milestone
2.4.60
Development

Successfully merging a pull request may close this issue.

fix oinkcodes with leading zeros Security-Onion-Solutions/securityonion
1 participant
@jertel