Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partner > User can not read the "All Partner" even user has "Global Read" access #1144

Closed
iPiyushPatel opened this issue Oct 6, 2021 · 2 comments · May be fixed by #1145
Closed

Partner > User can not read the "All Partner" even user has "Global Read" access #1144

iPiyushPatel opened this issue Oct 6, 2021 · 2 comments · May be fixed by #1145
Assignees
@daniel-leod
Labels
bug Something isn't working permissions
Projects
Cord - Public

Comments

@iPiyushPatel
Copy link

iPiyushPatel commented Oct 6, 2021 •
edited by sync-by-unito bot
Loading

Roles: FinacialAnalyst

Describe the bug
Partner > User can not read the All Partner even user has Global Read access

Steps to Reproduce

  1. Login as an admin user
  2. Create the partner
  3. Log in as a FinacialAnalyst user
  4. Find a created partner

Expected Result
User should be able to read the Partner

Actual Result
User can not read the All Partner even user has Global Read access

Note: Partner which is added in the project(with a member of FinacialAnalyst) those are displayed.

See Video -

Partner-User-can-not-read-the-.All-Partner.-even-user-has-.Global-Read.-access.mp4

See Screenshot -
image

CordAPIV3# 258a523
cord-field# 684cfb8

┆Issue is synchronized with this Monday item by Unito
@iPiyushPatel iPiyushPatel added bug Something isn't working permissions labels Oct 6, 2021
@daniel-leod daniel-leod self-assigned this Jun 15, 2022
@daniel-leod
Copy link
Contributor

I think this is working fine, partner names are hidden if the permission field sensitivity doesn't match.

@CarsonF What do you think about it?

@daniel-leod daniel-leod mentioned this issue Jul 8, 2022
Closed
@daniel-leod daniel-leod transferred this issue from SeedCompany/cord-api-v3 Jul 8, 2022
@daniel-leod daniel-leod mentioned this issue Jul 8, 2022
Open
@daniel-leod
Copy link
Contributor

However, if a user without the correct permissions tries to view a partner's details the UI crashes so I attached a PR that can fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-leod daniel-leod

Labels
bug Something isn't working permissions
Projects
No open projects
Cord - Public
  
Project Backlog (someday)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak partner details SeedCompany/cord-field
3 participants
@iPiyushPatel @sethmcknight @daniel-leod