removed tss-react from cord-field - 3466480946 #1164
Conversation
andrewmurraydavid
force-pushed
the
remove-tss-react
branch
2 times, most recently
from
dd89666
to
1f396fb
Compare
There was a problem hiding this comment.
I think I like this. It does "clutter" the jsx a bit more, but I think it's better to have those styles close to their usage. I've often found myself asking "what does this class do" and having to jump back and forth between styling at top and usage in jsx tree.
So I'm good with this if you like it 👍
|
Will you squash/fixup that second commit as well? |
|
@CarsonF |
Yeah I'd just prefer that "clean up" commits get squashed so we are left with single purpose commits. |
andrewmurraydavid
force-pushed
the
remove-tss-react
branch
from
bc1e2eb
to
1182a69
Compare
andrewmurraydavid
changed the title
| @@ -1,59 +1,19 @@ | |||
| import { Badge, Grid, TooltipProps, Typography } from '@mui/material'; | |||
| import { Badge, Grid, Theme, TooltipProps, Typography } from '@mui/material'; | |||
There was a problem hiding this comment.
The styling changes in this file are overly complicated and doing incorrect things. I'll expand/help later.
andrewmurraydavid
changed the title
sethmcknight
changed the title
sethmcknight
changed the title
┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466487404