Bug signing 1-of-2 multisig transaction when recipient is same wallet

[kdmukai]

Both keys are SeedSigner testnet devices in Specter.

Transaction is sending coins back to a new addr in the same wallet.

SeedSigner is hanging on "Parsing PSBT"

Traceback (most recent call last):
  File "main.py", line 12, in <module>
    controller.start(DEBUG)
  File "/home/pi/seedsigner/controller.py", line 69, in start
    self.show_main_menu()
  File "/home/pi/seedsigner/controller.py", line 91, in show_main_menu
    ret_val = self.show_sign_transaction()
  File "/home/pi/seedsigner/controller.py", line 339, in show_sign_transaction
    signer.parse_psbt(raw_pbst)
  File "./helpers/psbt_signer.py", line 76, in parse_psbt
    (self.change, self.fee, self.spend, self.destinationaddress) = PSBTSigner.change_fee_spend_amounts(self.tx, self.inp_amount, policy, self.seed_storage.get_network())
  File "./helpers/psbt_signer.py", line 260, in change_fee_spend_amounts
    return (change, fee, spend, destinationaddress)
UnboundLocalError: local variable 'destinationaddress' referenced before assignment

I can confirm that the same device/seed works fine signing a tx for an address in a different wallet. So it's just the self-send/cycling coins that seems to cause problems.

[SeedSigner]

We had this come up just last night and I believe @newtonick has some new code in his add_wallet_support branch that resolved this?

[newtonick]

@kdmukai do you remember which branch or release you found this issue on?

[newtonick]

moving to PSBTParser has resolved this issue.

[SeedSigner]

Going to wait until the change gets worked into a release, then will close this.

[newtonick]

@SeedSigner I believe this issue can be closed

[SeedSigner]

Thank you for the reminder.