Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing messages that overflow raise "TextDoesNotFit" exception #570

Closed
jdlcdl opened this issue Jul 13, 2024 · 2 comments
Closed

Signing messages that overflow raise "TextDoesNotFit" exception #570

jdlcdl opened this issue Jul 13, 2024 · 2 comments

Comments

@jdlcdl
Copy link

jdlcdl commented Jul 13, 2024

Reported in the main telegram group, within the past hour:

photo_2024-07-13_10-38-30

Hello Guys! I mine via the Ocean Pool and wanted to set up the "Lightning payout". To do this you need to have a Bolt-12 address or sign this address. I use Sparrow Wallet with Seedsigner. When I want to sign the message from Ocean, this error message appears because the message is too long and the Seedsigner cannot display it. Just a suggestion to the community in case this could be fixed in the future. Best regards!

This happens when the text has nowhere to cleanly break to a new line.

if len(text.split()) == 1 and not allow_text_overflow:

I had resolved this in the past for an experimental multilanguage branch, and it was to not fail on overflow... but then the user would be signing a message that they have not fully viewed on seedsigner screen.

@Lagrang3
Copy link

This is the same issue described in #550

@jdlcdl
Copy link
Author

jdlcdl commented Jul 15, 2024

This is the same issue described in #550

Thank you @Lagrang3, I'll close this one.

@jdlcdl jdlcdl closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants