Piglin Trader Progression line #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J3fftw1
requested changes
Jun 17, 2022
src/main/java/dev/sefiraat/netheopoiesis/api/plant/netheos/NetheoBalls.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/sefiraat/netheopoiesis/api/plant/netheos/NetheoBalls.java
Show resolved
Hide resolved
src/main/java/dev/sefiraat/netheopoiesis/implementation/netheos/Paste.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/sefiraat/netheopoiesis/implementation/netheos/Paste.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/sefiraat/netheopoiesis/implementation/tools/MixingQuartz.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/sefiraat/netheopoiesis/implementation/tools/MixingQuartz.java
Outdated
Show resolved
Hide resolved
| // Get the itemstack then add the flavour volume to the PDC, line to the lore | ||
| final ItemStack stack = ball.getSlimefunItemStack().clone(); | ||
| final ItemMeta itemMeta = stack.getItemMeta(); | ||
| final List<String> lore = itemMeta.getLore(); |
There was a problem hiding this comment.
Have you tested spamming this since we know lore checks are extremely heavy
There was a problem hiding this comment.
We can do some performance checks, but as it's manual use only, I can allow a higher overhead
src/main/java/dev/sefiraat/netheopoiesis/listeners/CrushingListener.java
Show resolved
Hide resolved
J3fftw1
requested changes
Jun 17, 2022
src/main/java/dev/sefiraat/netheopoiesis/api/plant/netheos/NetheoBalls.java
Outdated
Show resolved
Hide resolved
J3fftw1
requested changes
Jun 17, 2022
src/main/java/dev/sefiraat/netheopoiesis/api/plant/netheos/Trade.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/sefiraat/netheopoiesis/api/plant/netheos/Trade.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/sefiraat/netheopoiesis/utils/StatisticUtils.java
Outdated
Show resolved
Hide resolved
J3fftw1
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the Wandering Piglin and the progression mechanics around it: