Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross addon #22

Merged
merged 2 commits into from Jul 19, 2022
Merged

Cross addon #22

merged 2 commits into from Jul 19, 2022

Conversation

Sefiraat
Copy link
Owner

@Sefiraat Sefiraat commented Jul 19, 2022

Allows items to be added to Netheo without warnings being thrown in the console as per Slimefun/Slimefun4#3608 - Waited 9 days to allow servers to update first.

@Sefiraat Sefiraat requested a review from J3fftw1 July 19, 2022 11:07
pom.xml Outdated Show resolved Hide resolved
Co-authored-by: J3fftw <44972470+J3fftw1@users.noreply.github.com>
Copy link
Collaborator

@J3fftw1 J3fftw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sefiraat
Copy link
Owner Author

Hold merging for now :)

@Sefiraat
Copy link
Owner Author

Ok, thought I found an issue but I was using the wrong build - all good ha

@Sefiraat Sefiraat merged commit 57ce410 into master Jul 19, 2022
@J3fftw1 J3fftw1 deleted the feature/cross_addon branch July 19, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants