Backend overhaul #111
Merged
Backend overhaul #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, BIG change |
ybw0014
reviewed
Jan 25, 2022
src/main/java/io/github/sefiraat/slimetinker/items/componentmaterials/CMManager.java
Outdated
Show resolved
Hide resolved
|
This is a bit of a massive PR, but I would love you to take a look over it if you have time. If you don't - please do not worry and, if you do, please do take your time, there is no rush :) |
ybw0014
requested changes
Jan 26, 2022
src/main/java/io/github/sefiraat/slimetinker/items/templates/ArmourDefinition.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/templates/ArmourTemplate.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/templates/ToolTemplate.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/templates/ToolTemplateExplosive.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/TinkerMaterial.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/TinkerMaterial.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/TinkerMaterial.java
Outdated
Show resolved
Hide resolved
|
reviewed 51 files, will review remaining files later |
ybw0014
reviewed
Jan 27, 2022
src/main/java/io/github/sefiraat/slimetinker/items/workstations/armourtable/ArmourTable.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/workstations/repairbench/RepairBench.java
Outdated
Show resolved
Hide resolved
...in/java/io/github/sefiraat/slimetinker/items/workstations/smeltery/TinkersSmelteryCache.java
Outdated
Show resolved
Hide resolved
...in/java/io/github/sefiraat/slimetinker/items/workstations/smeltery/TinkersSmelteryCache.java
Outdated
Show resolved
Hide resolved
...in/java/io/github/sefiraat/slimetinker/items/workstations/smeltery/TinkersSmelteryCache.java
Outdated
Show resolved
Hide resolved
...in/java/io/github/sefiraat/slimetinker/items/workstations/smeltery/TinkersSmelteryCache.java
Outdated
Show resolved
Hide resolved
.../java/io/github/sefiraat/slimetinker/items/workstations/swappingstation/SwappingStation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/workstations/tooltable/ToolTable.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/utils/ItemUtils.java
Outdated
Show resolved
Hide resolved
ybw0014
reviewed
Jan 27, 2022
src/main/java/io/github/sefiraat/slimetinker/items/templates/RepairkitTemplate.java
Outdated
Show resolved
Hide resolved
ybw0014
previously requested changes
Jan 27, 2022
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
|
I don't understand why my new reviews are outdated. |
I probably did something dumb :D - I can see them all so this is great, thanks! |
ybw0014
requested changes
Jan 27, 2022
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/slimetinker/items/tinkermaterials/setup/Traits.java
Outdated
Show resolved
Hide resolved
|
It's ... outdated again. |
|
Nice, ill await the in-live feedback and merge tomorrow |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix my bad code as much as possible without changing anything breaking.
and anything else to un-dumb.
This will be followed by a second pull to convert all tools to proper PDC Types which will need a much longer lead in time.