Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlimeTinker armor with locked tool can dupe blocks #62

Closed
ybw0014 opened this issue Sep 23, 2021 · 4 comments
Closed

SlimeTinker armor with locked tool can dupe blocks #62

ybw0014 opened this issue Sep 23, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ybw0014
Copy link
Collaborator

ybw0014 commented Sep 23, 2021

Description (Required)

When wearing Tinker's armor and use a locked tool to break blocks, the block is still here and generates drops.
Without Tinker's armor, there are no drops.

Steps to reproduce the Issue (Required)

Video: https://youtu.be/QXXgD1sieo8

  1. Make any piece of Tinker's armor.
  2. Get a locked tool from /sf cheat or someone else (usually from shop). Here I get a cobalt pickaxe.
  3. Wear that piece of armor, and break any block.
  4. Some blocks will generate drops.

Some server owners sent me vids that they can dupe shulker boxes and chests, but I cannot reproduce that.

Expected behavior (Required)

No drops.

Server Log / Error Report

No error log in console.

Environment (Required)

  • Minecraft Version: 1.16.5
  • CS-CoreLib Version:
  • Slimefun Version: 971
  • Plugin Version: 36

Only Slimefun and SlimeTinker are installed.

@ybw0014 ybw0014 added the bug Something isn't working label Sep 23, 2021
@ybw0014 ybw0014 self-assigned this Sep 23, 2021
@Sefiraat
Copy link
Owner

Nice find. Let me know if you need help - I have tested annotating to LOWEST and ignoreCancelled and this still happens so, unless i'm missing something, we may need to check for SlimefunItem#canUse() directly?

@ybw0014
Copy link
Collaborator Author

ybw0014 commented Sep 23, 2021

Looks like it is fixed in build 37, so I will close this issue.

@ybw0014 ybw0014 closed this as completed Sep 23, 2021
@Sefiraat
Copy link
Owner

Oh damn I must have screwed up my branches as my testing was not meant to be in that push, I wasn’t overly happy with what I did, if you have anything close to a better implementation feel free to change it >_< this is why I should rush crap out during my breaks. Sorry.

@ybw0014
Copy link
Collaborator Author

ybw0014 commented Sep 23, 2021

Fine, but I will still make pull requests first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants