Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamHandler: Set $useLocking to true by default #1054

Closed
tomsommer opened this issue Sep 13, 2017 · 1 comment
Closed

StreamHandler: Set $useLocking to true by default #1054

tomsommer opened this issue Sep 13, 2017 · 1 comment

Comments

@tomsommer
Copy link

tomsommer commented Sep 13, 2017

Would it not make sense to set $useLocking to true by default? Otherwise you risk random concurrency/permission errors.

* @param Boolean $useLocking Try to lock log file before doing any writes

* @param Boolean $useLocking Try to lock log file before doing any writes

@Seldaek
Copy link
Owner

Seldaek commented Jun 17, 2018

As per #379 - this is only an issue if you log long lines or in very odd setups. For most use cases locking isn't needed even with high concurrency, so I don't think it's a good idea to enable by default.

@Seldaek Seldaek closed this as completed Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants