Add Record/Level/LevelName type aliases and improve phpstan type coverage to level 8 #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
changed the title
|
🚀 , @Seldaek minor casing-consistency-thingy for which I am not sure it justifies creating an issue: both @inheritDoc and @inheritdoc are used in PHPDoc. PHP-CS-Fixer/PHP-CS-Fixer#5141 indicates that |
Seldaek
added a commit
that referenced
this pull request
Jul 8, 2021
|
@holtkamp ok, not entirely sure if that is still accurate as fixing it didn't seem to change anything (I'd have expected something to break at least). But anyway it's fixed, thanks for pointing it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many new type annotations, a few small code tweaks/fixes 👍🏻