Added $logDepth which you can used to close log depth check.
#1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
reviewed
Jun 8, 2022
| */ | ||
| private $logDepth = 0; | ||
| private $logDepth; |
There was a problem hiding this comment.
Explicit null is better as it doesn't break with typed properties (3.x uses typed props and this will merge into it so rather be prepared)
Suggested change
| private $logDepth; | |
| private $logDepth = null; |
Seldaek
added a commit
that referenced
this pull request
Jun 8, 2022
|
Decided to do this differently, see 9c1566a - It'll be part of 2.7.0 when I get to it. |
|
So I think you can already update your conflict rule to conflict with 2.6.*, and add a method_exists() check to disable that feature if the method is present? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1672