Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lines in stacktraces broken on Windows in some cases #1720

Closed
abordage opened this issue Jun 26, 2022 · 1 comment
Closed

New lines in stacktraces broken on Windows in some cases #1720

abordage opened this issue Jun 26, 2022 · 1 comment
Labels
Milestone

Comments

@abordage
Copy link
Contributor

abordage commented Jun 26, 2022

Monolog version 2

In the log:

#13 {...}\\laravel\\vendor\\laravel\
ova\\src\\Http\\Middleware\\Authorize.php(18): {...}
#14 {...}\\laravel\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(180): {...}
#15 {...}\\laravel\\vendor\\laravel\
ova\\src\\Http\\Middleware\\BootTools.php(20): {...}
#16 {...}\\laravel\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(180): {...}
#17 {...}\\laravel\\vendor\\laravel\
ova\\src\\Http\\Middleware\\DispatchServingNovaEvent.php(24): {...}
#18 {...}\\laravel\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(180): {...}

Must be:

#13 {...}\\laravel\\vendor\\laravel\\nova\\src\\Http\\Middleware\\Authorize.php(18): {...}
#14 {...}\\laravel\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(180): {...}
#15 {...}\\laravel\\vendor\\laravel\\nova\\src\\Http\\Middleware\\BootTools.php(20): {...}
#16 {...}\\laravel\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(180): {...}
#17 {...}\\laravel\\vendor\\laravel\\nova\\src\\Http\\Middleware\\DispatchServingNovaEvent.php(24): {...}
#18 {...}\\laravel\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(180): {...}

The bug is the same as #1629
It is recommended to disable allowInlineLineBreaks, but method includeStacktraces automatically turns on allowInlineLineBreaks (see LineFormatter.php#L54-L63)

@abordage
Copy link
Contributor Author

I created a PR which may not cover all cases, but fixes the current bug and doesn't break the logic

@Seldaek Seldaek added this to the 2.x milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants