Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that restore_error_handler will not be executed some times. #1815

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

limingxinleo
Copy link
Contributor

No description provided.

@limingxinleo
Copy link
Contributor Author

hyperf/hyperf#2583

@Seldaek
Copy link
Owner

Seldaek commented Jun 21, 2023

I don't quite understand why they get "Warning: Invalid callback Monolog\Handler\StreamHandler::customErrorHandler, cannot access private method Monolog\Handler\StreamHandler::customErrorHandler()"

As far as I can tell the current code is fine and if it fails it does not throw so the try/catch shouldn't be needed? https://3v4l.org/NOrFI

@Seldaek Seldaek added this to the 2.x milestone Jun 21, 2023
@limingxinleo
Copy link
Contributor Author

@Seldaek Could you please take a look at this.

https://3v4l.org/e3L7U

Thanks.

@Seldaek
Copy link
Owner

Seldaek commented Jun 22, 2023

Ok I get it now, fopen throws somehow here, I don't know why it does for your users tho as it shouldn't but ok, then the error handler isn't properly reset and from an outside scope it fails. Thanks for the example. I'll merge this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants