Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there documentation for configuring modelsetting.json? #232

Closed
lianxmfor opened this issue Jul 12, 2021 — with Board Genius Sync · 2 comments · Fixed by #318
Closed

Is there documentation for configuring modelsetting.json? #232

lianxmfor opened this issue Jul 12, 2021 — with Board Genius Sync · 2 comments · Fixed by #318
Assignees

Comments

Copy link
Contributor

Is there documentation for configuring modelsetting.json? I would like to configure the metadata of the model, input/output tensor, etc.

@adriangonz
Copy link
Contributor

Hey @lianxmfor, good catch!

Unfortunately, we don't have any docs yet for the different settings (both at the server and model levels). We are planning to add a section documenting this on the short-term as part of MLServer's new docs site.

In the meantime, although not ideal, it should be relatively straightforward to see the different fields directly in the ModelSettings class of the mlserver/settings.py file.

class ModelSettings(BaseSettings):
class Config:
env_prefix = ENV_PREFIX_MODEL_SETTINGS
name: str = ""
# Model metadata
platform: str = ""
versions: Optional[List[str]] = []
inputs: Optional[List[MetadataTensor]] = []
outputs: Optional[List[MetadataTensor]] = []
# Custom model class implementation
implementation: PyObject = "mlserver.model.MLModel" # type: ignore
# Model parameters are meant to be set directly by the MLServer runtime.
# However, it's also possible to override them manually.
parameters: Optional[ModelParameters] = None

You can also check some of the internal examples, like the one used for our tests: https://github.com/SeldonIO/MLServer/blob/e34c4b9fe2f646e3f890bd49b0dbfb8c8ba36dab/tests/testdata/model-settings.json

I'll keep this issue opened as part of the ongoing documentation efforts.

@lianxmfor
Copy link
Contributor Author

Thank you for providing so much information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants