Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure uvicorn logging #530

Closed
pablobgar opened this issue Mar 22, 2022 · 1 comment · Fixed by #531
Closed

Allow to configure uvicorn logging #530

pablobgar opened this issue Mar 22, 2022 · 1 comment · Fixed by #531

Comments

@pablobgar
Copy link
Contributor

pablobgar commented Mar 22, 2022 •
edited
Loading

Trying to add custom handlers to the application logger we have found that the uvicorn ones are not working as expected. It seems that uvicorn overrides the logging configuration when the Config object is initialized.

It would be nice to allow users to configure the uvicorn logger. This can be done by setting the path to a logging configuration file when creating uvicorn's Config object.
@pablobgar pablobgar mentioned this issue Mar 22, 2022
Merged
@pablobgar
Copy link
Contributor Author

A PR has been added with a proposal to solve this issue but it may not be the best solution. It is open to other proposals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uvicorn logging settings pablobgar/MLServer
1 participant
@pablobgar