Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated utils._types logic #763

Closed
Tracked by #806
mauicv opened this issue Mar 17, 2023 · 0 comments · Fixed by #829
Closed
Tracked by #806

Remove duplicated utils._types logic #763

mauicv opened this issue Mar 17, 2023 · 0 comments · Fixed by #829
Assignees

Comments

@mauicv
Copy link
Collaborator

mauicv commented Mar 17, 2023

The following logic here:

# Literal for typing
if sys.version_info >= (3, 8):
    from typing import Literal  # noqa
else:
    from typing_extensions import Literal  # noqa

in the utils._types file is unnecessary as typing_extensions already does this under the hood. Hence we should default to importing Literal from typing_extensions directly instead of from utils_types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant