Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return data from od fit methods #813

Closed
2 tasks done
Tracked by #806
mauicv opened this issue Jun 12, 2023 · 3 comments · Fixed by #835
Closed
2 tasks done
Tracked by #806

Return data from od fit methods #813

mauicv opened this issue Jun 12, 2023 · 3 comments · Fixed by #835
Assignees

Comments

@mauicv
Copy link
Collaborator

mauicv commented Jun 12, 2023

  • Currently when you can fit on gmm and svm detectors the user can specify verbosity, however, we don't return any logs of the fit process despite computing them internally, These should be returned.
  • Also, make sure that returned data is consistent.
@mauicv mauicv self-assigned this Jun 12, 2023
@mauicv mauicv mentioned this issue Jun 12, 2023
18 tasks
@jklaise
Copy link
Member

jklaise commented Jun 12, 2023

Do you mean actually return some object with the logs or just fiddling with the logging levels?

Bigger than this issue, but it's a great point to consider how we could expose application level logging. From our point of view, we just need to sprinkle logging statements, but then it's up to the user/application to define where to log and which level to expose (as in, our verbose) flags would not affect these. Good to check with scikit-learn as they have verbose flags too.

@mauicv
Copy link
Collaborator Author

mauicv commented Jun 12, 2023

I mean some object with the logs although perhaps logging would be better. Specifically in the case of gmm we allow a convergence threshold to be set. The training ends on the basis of this criterion being met or the training process running for max_epochs. I felt this should be returned to the user so they can check if this has occured or at least set this value on the detector somewhere.

@jklaise
Copy link
Member

jklaise commented Jun 12, 2023

OK I see, it makes sense to both return something that can be programatically checked and also logging progress, both of which are kind of orthogonal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants