Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate an OpenAPI spec and SDK #1682

Closed
ukclivecox opened this issue Apr 11, 2020 · 8 comments
Closed

Autogenerate an OpenAPI spec and SDK #1682

ukclivecox opened this issue Apr 11, 2020 · 8 comments

Comments

@ukclivecox
Copy link
Contributor

At present we do not have python or other language SDKs for manipulating the SeldonDeployment resources.

  • Add openApi schema and generate SDK for python
@ukclivecox ukclivecox added triage Needs to be triaged and prioritised accordingly priority/p2 and removed triage Needs to be triaged and prioritised accordingly labels Apr 11, 2020
@RexG
Copy link

RexG commented May 12, 2020

+1;

really like the idea, working with/preparing yaml config is not systematic and straightforward;
please consider providing some SDKs for model deployment;

btw, if SDK for golang will be great LOL

@adriangonz
Copy link
Contributor

@RexG if all you want is to manipulate SeldonDeployment resources, you could also import the type definition directly as:

import (
 sc "github.com/seldonio/seldon-core/operator/apis/machinelearning.seldon.io/v1"
)

// ...

sdep := sc.SeldonDeployment{...}

@RexG
Copy link

RexG commented May 13, 2020

thank you @adriangonz

the goal is to deploy model on Seldon using SDK/API;

all i can find are some struct, e.g. the SeldonDeployment struct; can you guide me how to use it to do the model deployment? any reference or example?

@adriangonz
Copy link
Contributor

I see! You are right @RexG, the SeldonDeployment struct will only allow you to define the resource and manipulate it, but not to deploy it.

However, wouldn't something like the Kubernetes' Go client solve that? You could use that client to essentially run kubectl apply programmatically.

Would that solve your use case? Otherwise, what else would you like to see in an SDK?

@RexG
Copy link

RexG commented May 14, 2020

Thank you @adriangonz

something like:

cli := Seldon.Client(url string)
restful_api := cli.deploy(SeldonDeployment())

then looks like i have to programmatically prepare the YAML configuration, and use k8s client to do the model deployment

@ukclivecox
Copy link
Contributor Author

We already have Go client libraries generated for kubernetes Go client so you should be able to do this: https://github.com/SeldonIO/seldon-core/tree/master/operator/client/machinelearning.seldon.io

Does this for your need?

@axsaucedo
Copy link
Contributor

Closing inactive issue

@asahalyft
Copy link

I see the issue has been closed. The original issue was to have python SDKs for manipulating the SeldonDeployment resources. Could you @cliveseldon @alexcoca please let us know on the availability of Python SDK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants