Hyphens in names cause the service orchestrator to start a grpc server

[mattpiatkus]

Seldon version 1.1
Kubernetes version 1.14

On my cluster, the following starts a grpc orchestrator rather than a rest one:

apiVersion: machinelearning.seldon.io/v1
kind: SeldonDeployment
metadata:
  name: fixed
spec:
  name: fixed-hyphenated
  protocol: seldon
  transport: rest
  predictors:
  - componentSpecs:
    - spec:
        containers:
        - image: seldonio/fixed-model:0.1
          name: classifier1
    graph:
      children: []
      name: classifier1
      type: MODEL
    name: default
    replicas: 1

With fixed-hyphenated reverted to just fixed, it correctly starts a rest server.

The problem also seems to occur with hyphens in the repository name, predictor name, etc. Repository names are a particular problem because (in my case) the name comes from the Google cloud project which can't be changed. I was only able to use a rest orchestrator for my image by hosting it on an entirely new project with no hyphens in the name.

[ukclivecox]

I tried this on 1.1.0 and seems to work fine. Can you check the output of kubectl get sdep -o yaml
I get:

apiVersion: v1
items:
- apiVersion: machinelearning.seldon.io/v1
  kind: SeldonDeployment
  metadata:
    creationTimestamp: "2020-06-02T13:47:23Z"
    generation: 1
    name: fixed
    namespace: default
    resourceVersion: "2147"
    selfLink: /apis/machinelearning.seldon.io/v1/namespaces/default/seldondeployments/fixed
    uid: 66a89de8-78ac-4648-9b78-c9151adf67f8
  spec:
    name: fixed-hyphenated
    predictors:
    - componentSpecs:
      - metadata:
          creationTimestamp: null
        spec:
          containers:
          - image: seldonio/fixed-model:0.1
            name: classifier1
            ports:
            - containerPort: 6000
              name: metrics
              protocol: TCP
            resources: {}
            volumeMounts:
            - mountPath: /etc/podinfo
              name: podinfo
      engineResources: {}
      graph:
        endpoint:
          service_host: localhost
          service_port: 9000
          type: REST
        implementation: UNKNOWN_IMPLEMENTATION
        name: classifier1
        type: MODEL
      labels:
        version: default
      name: default
      replicas: 1
      svcOrchSpec: {}
    protocol: seldon
    transport: rest
  status:
    address:
      url: http://fixed-default.default.svc.cluster.local:8000/api/v1.0/predictions
    deploymentStatus:
      fixed-default-0-classifier1:
        availableReplicas: 1
        replicas: 1
    replicas: 1
    serviceStatus:
      fixed-default:
        grpcEndpoint: fixed-default.default:5001
        httpEndpoint: fixed-default.default:8000
        svcName: fixed-default
      fixed-default-classifier1:
        httpEndpoint: fixed-default-classifier1.default:9000
        svcName: fixed-default-classifier1
    state: Available
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

I install Ambassador and port-fowarded to 8003 and ran:

curl -d '{"data": {"ndarray":[[1.0, 2.0, 5.0]]}}'    -X POST http://localhost:8003/seldon/default/fixed/api/v1.0/predictions    -H "Content-Type: application/json"

{"data":{"names":[],"ndarray":[1,2,3,4]},"meta":{}}

[axsaucedo]

@mattpiatkus any updates?

[ukclivecox]

Please reopen if can be reproduced