Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI Validation for PredictiveUnits limited to 5 levels #1864

Closed
ukclivecox opened this issue May 22, 2020 · 0 comments · Fixed by #2339
Closed

OpenAPI Validation for PredictiveUnits limited to 5 levels #1864

ukclivecox opened this issue May 22, 2020 · 0 comments · Fixed by #2339
Assignees
Projects
Milestone

Comments

@ukclivecox
Copy link
Contributor

As CRD OpenApi Validation does not allow recursive definitions at present the CRD has a fixed expanded definition of the children Predictive Units:

https://github.com/SeldonIO/seldon-core/blob/master/operator/config/crd/patches/graph_children.yaml

This needs to be expanded as a short term fix to more levels as users are hitting these levels of graph complexity.

A long term solution would be when CRD OpenAPI validation allows recursive definitions.
At present this seems to have not moved forward: kubernetes/kubernetes#54579

@ukclivecox ukclivecox added this to To do in 1.3 via automation Jun 25, 2020
@ukclivecox ukclivecox added this to the 1.3 milestone Jun 25, 2020
@ukclivecox ukclivecox self-assigned this Aug 23, 2020
@ukclivecox ukclivecox moved this from To do to In progress in 1.3 Aug 27, 2020
@ukclivecox ukclivecox moved this from In progress to In Review in 1.3 Aug 28, 2020
1.3 automation moved this from In Review to Done Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1.3
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant