Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More restricted deployment rbac for seldon-core #2662

Closed
anggao opened this issue Nov 18, 2020 · 2 comments
Closed

More restricted deployment rbac for seldon-core #2662

anggao opened this issue Nov 18, 2020 · 2 comments
Labels
awaiting-feedback

Comments

@anggao
Copy link
Contributor

anggao commented Nov 18, 2020

Right now seldon-core service account needs cluster level permission to manage all deployments,
can we change it to namespace bound instead of cluster level ?

https://github.com/SeldonIO/seldon-core/blob/master/operator/config/rbac/role.yaml#L39
@anggao anggao added the triage Needs to be triaged and prioritised accordingly label Nov 18, 2020
@ukclivecox
Copy link
Contributor

From the discussion in the community call can this be closed now?
You can use namespace operator for this?

@ukclivecox ukclivecox added awaiting-feedback and removed triage Needs to be triaged and prioritised accordingly labels Nov 20, 2020
@anggao
Copy link
Contributor Author

anggao commented Nov 20, 2020 •
edited
Loading

@cliveseldon Yeah let's close this and I will check whether kubebuilder support dynamic MultiNamespacedCacheBuilder
now. We use it to watch a specific set of namespaces but it needs operator restarts when the list changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting-feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anggao @ukclivecox