ArgoCD OutOfSync if SeldonDeployment includes mountpoint

[RafalSkolasinski]

Describe the bug

In GitOps with ArgoCD setup if SeldonDeployment contains mountpoint argo reports incorrect OutOfSync error.
This goes away if one include

  ignoreDifferences:
  - group: machinelearning.seldon.io
    kind: SeldonDeployment
    jsonPointers:
    - /spec/predictors/0/componentSpecs/0/spec/containers/0/volumeMounts

in the Application definition.

See argocd diffing customisation.

To reproduce

1. Install SC and ArgoCD
2. Create following PVC

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: test-pvc
  namespace: gitops-namespace
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 20Gi

3. Add following deployment via gitops

apiVersion: machinelearning.seldon.io/v1alpha2
kind: SeldonDeployment
metadata:
  name: sklearn
spec:
  name: iris
  predictors:
  - componentSpecs:
    - spec:
        containers:
        - name: classifier
          resources:
            requests:
              memory: 50Mi
          volumeMounts:
          - name: pvc-storage
            mountPath: /new-pvc-location
        volumes:
        - name: pvc-storage
          persistentVolumeClaim:
            claimName: test-pvc

    graph:
      implementation: SKLEARN_SERVER
      modelUri: gs://seldon-models/sklearn/iris
      name: classifier
    name: default
    replicas: 1

Observe incorrect OutOfSync state.

Expected behaviour

ArgoCD does not report diff.

Environment

SC 1.5.x with ArgoCD 1.7.x or 1.8.x.

Model Details

[RafalSkolasinski]

Temporary workaround is to add

  ignoreDifferences:
  - group: machinelearning.seldon.io
    kind: SeldonDeployment
    jsonPointers:
    - /spec/predictors/0/componentSpecs/0/spec/containers/0/volumeMounts

to the argo application resource as per argocd documentation.

Problem will be solved by resolving #2817.

[omerfsen]

+1

[omerfsen]

Thank you for fixing #2817 as it will clear all "OutOfSnyc" Errors on ArgoCD even if I had a long list of ignoreDifferences