Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seldon-batch-processor Install Instruction Missing #2956

Closed
snowneji opened this issue Feb 15, 2021 · 7 comments
Closed

seldon-batch-processor Install Instruction Missing #2956

snowneji opened this issue Feb 15, 2021 · 7 comments
Labels
triage Needs to be triaged and prioritised accordingly

Comments

@snowneji
Copy link

Hello, I've been exploring the batch processing of SeldonCore, but I couldn't find documentation that shows how to install the seldon-batch-processor. Can anyone show me how to do it? And is it possible to add it to the documentation like here: https://docs.seldon.io/projects/seldon-core/en/latest/servers/batch.html

@snowneji snowneji added the triage Needs to be triaged and prioritised accordingly label Feb 15, 2021
@omerfsen
Copy link
Contributor

it comes default by any docker images but you can install locally on your machine with

pip3 install seldon-core

@snowneji
Copy link
Author

@omerfsen Thanks for the help. Just wondering is this the correct image? seldonio/seldon-core-s2i-python3

@omerfsen
Copy link
Contributor

@omerfsen Thanks for the help. Just wondering is this the correct image? seldonio/seldon-core-s2i-python3

all seldon-core-s2i-pythonxx images have it

@snowneji
Copy link
Author

snowneji commented Feb 16, 2021

@omerfsen Actually I found an issue in the base Docker image (seldon-core-s2i-python3:0.18). In setup.py the entry_points does not include seldon-batch-processor. But in the updated Github repo setup.py has that:https://github.com/SeldonIO/seldon-core/blob/master/python/setup.py

Also the seldon-core pkg attached with the image doesn't have seldon_core/batch_processor.py module
My screenshot of the setup.py in the Docker image:
image

@snowneji
Copy link
Author

I guess it has to do with versions. The default seldon-core pkg in the image seldon-core-s2i-python3:0.18 is 1.0.2, which doesn't have the batch-processing functionality. Just wondering which version of the image contains the batch processor?

@axsaucedo
Copy link
Contributor

From memory, batch processing may not have been introduced until around version 1.2.x

@snowneji
Copy link
Author

1.2.0 handles both real-time and batch well, thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

No branches or pull requests

3 participants