Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The /aggregate endpoint is wrongly called if we have a COMBINER with SEND_FEEDBACK method activated #3139

Closed
fernandocamargoai opened this issue Apr 23, 2021 — with Board Genius Sync · 0 comments · Fixed by #3152

Comments

Copy link

I have a COMBINER in which I want to have the /send-feedback endpoint. So, I have the following configuration:

graph:
        children:
          - children: [ ]
            name: recommender
            type: MODEL
            endpoint:
              type: REST
        endpoint:
          type: REST
        name: cold-start-recommender
        type: COMBINER
        methods: ["AGGREGATE", "SEND_FEEDBACK"]

Then, I've noticed that when I send feedback, the /send-feedback of my recommender is invoked and then the /aggregate of cold-start-recommender is called (and an error is raised because the message is unexpected) instead of the /send-feedback. It can be seen in the following log (in which I've sent a prediction and a feedback request):

{"level":"debug","ts":1619211214.6164505,"logger":"JSONRestClient","msg":"Calling HTTP","URL":"http://localhost:9000/predict"}
{"level":"debug","ts":1619211214.749554,"logger":"JSONRestClient","msg":"Calling HTTP","URL":"http://localhost:9001/aggregate"}
{"level":"debug","ts":1619211239.8898373,"logger":"JSONRestClient","msg":"Calling HTTP","URL":"http://localhost:9000/send-feedback"}
{"level":"debug","ts":1619211239.9361725,"logger":"JSONRestClient","msg":"Calling HTTP","URL":"http://localhost:9001/aggregate"}
{"level":"info","ts":1619211239.947629,"logger":"JSONRestClient","msg":"httpPost failed","response code":500}

After talking to @cliveseldon on Slack, he said that it's probably because of this line.

@ukclivecox ukclivecox added this to Triage in Backlog via automation Apr 25, 2021
@ukclivecox ukclivecox self-assigned this Apr 25, 2021
@ukclivecox ukclivecox moved this from Triage to Next Sprint in Backlog Apr 25, 2021
@axsaucedo axsaucedo changed the title The /aggregate endpoint is wrongly called if we have a COMBINER with SEND_FEEDBACK method activated OSS-231: The /aggregate endpoint is wrongly called if we have a COMBINER with SEND_FEEDBACK method activated Apr 26, 2021
@axsaucedo axsaucedo changed the title OSS-231: The /aggregate endpoint is wrongly called if we have a COMBINER with SEND_FEEDBACK method activated The /aggregate endpoint is wrongly called if we have a COMBINER with SEND_FEEDBACK method activated Apr 26, 2021
@ukclivecox ukclivecox added this to To do in MLOPs Sprint 7 (ending 14/4/2021) via automation Apr 29, 2021
@ukclivecox ukclivecox removed this from Next Sprint in Backlog Apr 29, 2021
@ukclivecox ukclivecox moved this from To do to In progress in MLOPs Sprint 7 (ending 14/4/2021) May 1, 2021
@ukclivecox ukclivecox moved this from In progress to Review in progress in MLOPs Sprint 7 (ending 14/4/2021) May 1, 2021
MLOPs Sprint 7 (ending 14/4/2021) automation moved this from Review in progress to Done May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants