Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any structure in custom field in metadata #3144

Closed
dmirecki opened this issue Apr 29, 2021 · 2 comments
Closed

Allow any structure in custom field in metadata #3144

dmirecki opened this issue Apr 29, 2021 · 2 comments
Assignees

Comments

@dmirecki
Copy link

I am working on a model for which I need to define what kind of data the model is able to process. I define some high level structure that describes the data and now I am trying to put it in the seldon's metadata. In this way, client can easily check what kind of data my model supports.

I tried to use custom field in metadata endpoint, but, unfortunately, the field only supports str -> str mapping. As I mentioned, I have to pass more complicated structure (nested dictionary, lists). From that stems my feature request to allow any structure in custom field in metadata.

@dmirecki dmirecki added the triage Needs to be triaged and prioritised accordingly label Apr 29, 2021
@ukclivecox ukclivecox added this to Triage in Backlog via automation Apr 29, 2021
@RafalSkolasinski
Copy link
Contributor

Hi @dmirecki,

The custom field is really meant to be tags or labels (so just str->str) but is named custom to avoid confusion with k8s labels or request tags.

What you can do is to specify type jsonData and then schema field should (as far as I remember) accept anything you define there, see https://docs.seldon.io/projects/seldon-core/en/latest/reference/apis/metadata.html#jsondata-input-output

@RafalSkolasinski RafalSkolasinski added awaiting-feedback and removed triage Needs to be triaged and prioritised accordingly labels Apr 29, 2021
@RafalSkolasinski RafalSkolasinski self-assigned this Apr 29, 2021
@RafalSkolasinski RafalSkolasinski moved this from Triage to Q&A in Backlog Apr 29, 2021
@dmirecki
Copy link
Author

Hi, thank you for response.

Your were right, schema in input and output accept any structure, so I can use that for my case.

Thank you!

@ukclivecox ukclivecox removed this from Q&A in Backlog May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants