Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle bad SemVer for CRD creation #3569

Closed
ukclivecox opened this issue Sep 4, 2021 · 0 comments · Fixed by #3570
Closed

handle bad SemVer for CRD creation #3569

ukclivecox opened this issue Sep 4, 2021 · 0 comments · Fixed by #3570
Assignees
Labels

Comments

@ukclivecox
Copy link
Contributor

For GKE the version returned by cc.discoveryClient.ServerVersion() can be of the form 1.20+ which does not parse normal semantic version check we use in Operator resulting in semver.NewConstraint(">= 1.18.0") returning false.

See

sv, err := cc.discoveryClient.ServerVersion()
if err != nil {
return nil, err
}
v, err := semver.NewVersion(sv.String())
if err != nil {
return nil, err
}
c, err := semver.NewConstraint(">= 1.18.0")
if err != nil {
return nil, err
}
check := c.Check(v)

@ukclivecox ukclivecox added bug triage Needs to be triaged and prioritised accordingly labels Sep 4, 2021
@ukclivecox ukclivecox self-assigned this Sep 4, 2021
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant