Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executor returns minimal information on http client failure #3625

Closed
mwm5945 opened this issue Sep 30, 2021 · 0 comments · Fixed by #3626
Closed

Executor returns minimal information on http client failure #3625

mwm5945 opened this issue Sep 30, 2021 · 0 comments · Fixed by #3626
Labels
bug

Comments

@mwm5945
Copy link
Contributor

mwm5945 commented Sep 30, 2021 •
edited

Describe the bug

When the executor HTTP client experiences an error (EX, a timeout), it only returns a 500 code header, with an empty body.

To reproduce

  1. Deploy model that takes a while (say 1s) with a very short timeout (say 500ms)
  2. Ensure Executor is enabled for deployment
  3. query the prediction endpoint
  4. observe the empty body and 500 response code.

Expected behaviour

A clearer response is returned from the executor, including the error from the executor.
@mwm5945 mwm5945 added bug triage Needs to be triaged and prioritised accordingly labels Sep 30, 2021
@mwm5945 mwm5945 changed the title Executor returns minimal information on http client failur Executor returns minimal information on http client failure Sep 30, 2021
@mwm5945 mwm5945 mentioned this issue Sep 30, 2021
Merged
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Executor Returns Clearer Errors on HTTP Failures mwm5945/seldon-core
2 participants
@ukclivecox @mwm5945