Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiversion is deprecated in notebooks/resources/ambassador-rbac.yaml #3677

Closed
westford14 opened this issue Oct 15, 2021 · 2 comments · Fixed by #3678
Closed

apiversion is deprecated in notebooks/resources/ambassador-rbac.yaml #3677

westford14 opened this issue Oct 15, 2021 · 2 comments · Fixed by #3678
Labels
bug triage Needs to be triaged and prioritised accordingly

Comments

@westford14
Copy link
Contributor

Describe the bug

The notebooks/resources/ambassador-rbac.yaml file is using a fully deprecated apiversion for the deployment. The manifest is using extensions/v1beta1, but this should now be apps/v1.

To reproduce

The kubectl apply -f notebooks/resources/ambassador-rbac.yaml command yields:

clusterrole.rbac.authorization.k8s.io/ambassador created
serviceaccount/ambassador created
clusterrolebinding.rbac.authorization.k8s.io/ambassador created
service/ambassador created
service/ambassador-admin created
error: unable to recognize "notebooks/resources/ambassador-rbac.yaml": no matches for kind "Deployment" in version "extensions/v1beta1"

Expected behaviour

Ideally it would create the deployment without triggering this error

Environment

  • Cloud Provider: Kind
  • Kubernetes Cluster Version: Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2", GitCommit:"092fbfbf53427de67cac1e9fa54aaa09a28371d7", GitTreeState:"clean", BuildDate:"2021-06-16T12:59:11Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"darwin/amd64"}
  • Deployed Seldon System Images: no seldon image being used

Model Details

No model is being used here.

@westford14 westford14 added bug triage Needs to be triaged and prioritised accordingly labels Oct 15, 2021
@westford14
Copy link
Contributor Author

i can also take this issue and open up a PR for this, this is a pretty small bug

@ukclivecox
Copy link
Contributor

Thanks that would be great @westford14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants