Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Annotations and Labels to be injected into helm chart templates #3699

Closed
mwm5945 opened this issue Oct 22, 2021 — with Board Genius Sync · 2 comments · Fixed by #3724
Closed

Allow for Annotations and Labels to be injected into helm chart templates #3699

mwm5945 opened this issue Oct 22, 2021 — with Board Genius Sync · 2 comments · Fixed by #3724
Assignees
Labels
triage Needs to be triaged and prioritised accordingly

Comments

Copy link
Contributor

mwm5945 commented Oct 22, 2021

It would be great if we could inject labels and/or annotations into some of the templates in the helm chart. this would be particularly helpful for the CRD which is quite large, and ArgoCD doesn't like the size of the metadata (particularly last-applied-configuration). We could inject an argo sync annotation to help avoid that issue.

@mwm5945 mwm5945 added the triage Needs to be triaged and prioritised accordingly label Oct 22, 2021
@ukclivecox
Copy link
Contributor

Seems reasonable can we discuss a PR

@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Nov 1, 2021
@seldondev seldondev added the triage Needs to be triaged and prioritised accordingly label Nov 1, 2021 — with Board Genius Sync
@mwm5945
Copy link
Contributor Author

mwm5945 commented Nov 4, 2021

@cliveseldon i've opened the above PR, but i've only added annotations to the CRD and the Deployment templates, as those are really the only places i can think of them being useful. I can also add a global annotation spec, and add them to each of the templates if you think thats a good idea. The PR is still a draft until what annotations we'd like to be added are finalized, then i'll udpate documentation, etc :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants